I'd have to say my favourites are: (though their feats may not have been as impacting as others...)
Huor, Tuor, Earendil, Fingolfin, Elendil, and of course the tragic hero of any true weeper's dreams; Feanor...
Huor was a loyal, utterly inconquerable man who was willing to die for his lord... the battle of innumerable tears was really his apex eh?
Tuor... such a legend, both a saviour and a trigger for the unfolding of Gondolin, WAS FAVOURED BY ULMO... a real bloke with a real sword... none of this black rubbish like his cousin.
Earendil... enough said!!
Fingolfin, wise, valiant, brave, loyal and a general nice fella... musta scared the jeebs outta morgoth i can tell you.
Elendil... all the virtue and worth of the edain, that was all but lost in Numenor... good looking too
Feanor: now you guys might say: why him, that shmuck started all this fuss, he was a self absorbed twit!!! - well i happen to like him
As for sam and frodo.... coughflukecoughcough
Aragorn might be just off the list, as would Glorfindel, Elrond and Imrahil.