In Tolkien's works there is no "black and white". There is no perfect character, not even the Valar. There are hardly any
completely evil characters. And even they did not begin evil.
There is some good and some bad in everyone. The fact that one is fighting against Morgoth doesn't make him an angel.
Personally, the first time I read The Sil I had a similar reaction, except that it was about Feanor's sons in particular. First Maedhros appeared a sensible enough guy, but then the second and third kinslayings and all that stuff...
And welcome to the Downs!